Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXE Support for null is not implemented yet #931

Closed
RolfWeilen opened this issue Jul 20, 2016 · 3 comments
Closed

PXE Support for null is not implemented yet #931

RolfWeilen opened this issue Jul 20, 2016 · 3 comments

Comments

@RolfWeilen
Copy link

RolfWeilen commented Jul 20, 2016

Relax-and-Recover (rear) Issue Template

Please fill in the following items before submitting a new issue:

  • rear version (/usr/sbin/rear -V):
    Relax-and-Recover 1.18 / Git
  • OS version (cat /etc/rear/os.conf or lsb_release -a):
  OS_VENDOR=RedHatEnterpriseServer
  OS_VERSION=7
  • rear configuration files (cat /etc/rear/site.conf or cat /etc/rear/local.conf):
  OUTPUT=PXE
  OUTPUT_URL=file:/var/lib/rear/output/
  OUTPUT_PREFIX_PXE=rearboot
  ISO_DEFAULT=manuel
  OUTPUT_URL=null
  BACKUP=TSM
  TIMESYNC=NTP
  TSM_RESULT_SAVE=n
  TSM_RESULT_FILE_PATH=""
  USE_DHCLIENT=y
  USE_STATIC_NETWORKING=n
   # Include only rootvg
  ONLY_INCLUDE_VG=(res9915vg00)
  # Add an group Entry
  
  GRUB_RESCUE=n

pmr_info.txt

  • Brief description of the issue
    When generate the pxe files:
  2016-07-19 09:34:34.597905922 Created pxelinux config 'rear-res9915' and symlinks for MAC adresses in /var/lib/rear/output
  2016-07-19 09:34:34.601938126 Including output/PXE/default/82_copy_to_net.sh
  2016-07-19 09:34:34.606798591 ERROR: BUG BUG BUG!  Support for null is not implemented yet. 
  === Issue report ===
  Please report this unexpected issue at: https://github.com/rear/rear/issues
  Also include the relevant bits from /var/log/rear/rear-res9915.log
  • Work-around, if any
    It works not workaround is needed
@jsmeix
Copy link
Member

jsmeix commented Jul 20, 2016

I find 'Support for .* is not implemented yet' in
usr/share/rear/output/PXE/default/82_copy_to_net.sh
usr/share/rear/output/RAMDISK/Linux-i386/90_copy_ramdisk.sh
usr/share/rear/output/default/95_copy_result_files.sh
as

case "$scheme" in
    ...
    (*) BugError "Support for $scheme is not implemented yet.";;

This shows that the root cause is your incorrect URL

OUTPUT_URL=file:/var/lib/rear/output/
...
OUTPUT_URL=null

and the incorrect duplicate setting of OUTPUT_URL.

See the rear documentation and the general RFC
how a URL must look like, e.g.:

nfs://lucky/temp/backup
cifs://lucky/temp
usb:///dev/sdb1
tape:///dev/nst0
file:///path
iso://backup/
sshfs://user@host/G/rear/
ftpfs://user:password@host/rear/ (the password part is optional)

I will fix the misleading error message.

@jsmeix
Copy link
Member

jsmeix commented Jul 20, 2016

With #932
rear now errors out instead of a BugError
for not implemented URI schemes because
it is not a bug in rear when some functionality
is not yet implemented.

FYI:
BugError is usually meant for things like

some code that is known to do "something" reliably
# success is mandatory to proceed (any failure is unexpected)
if not "something" then BugError "Failed to do something"

Another example is in lib/_input-output-functions.sh

BugError "Forbidden use of trap with '$@'. Use AddExitTask instead."

which detects a real programming bug.

jsmeix added a commit that referenced this issue Jul 21, 2016
…mplemented_URI_scheme_issue931

Error out instead of BugError for not implemented URI schemes.

See #931

And some other fixes:

First steps to be prepared for 'set -e' which means
replaced COMMAND ; StopIfError
with COMMAND || Error

In output/PXE/default/82_copy_to_net.sh
error out in case of "Problem transferring..."
for each result file (before it only errors out
in case of "Problem transferring..." for the last
result file because Error was after the for loop)
@jsmeix jsmeix added this to the Rear v1.19 milestone Jul 21, 2016
@jsmeix
Copy link
Member

jsmeix commented Jul 21, 2016

@RolfWeilen
FYI
how to test current rear GitHub master code:

# git clone https://github.com/rear/rear.git
# cd rear
# vi etc/rear/local.conf
# usr/sbin/rear -d -D mkbackup

i.e. configure and run rear from within the directory
whereto the rear master code was cloned from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants