Update 50_guess_bootloader.sh #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'tail -n1' to get onyl the last value if there are more than one and because getting values from sysconfig files is like sourcing a shell script it is the last setting that matters. Cf. http://stackoverflow.com/questions/2871930/how-to-retrieve-value-from-etc-sysconfig-in-python that reads (excerpt): source /etc/sysconfig/FOO echo $MY_VALUE and http://ftp.novell.hu/pub/mirrors/ftp.novell.com/forge/library/SUSE%20Package%20Conventions/spc_sysconfig.html that reads (excerpts): The configuration is easily readable by shell scripts The sysconfig files are plain text files. The setting is defined by pairs {VARIABLE,value} the following way, like shell variables: VARIABLE=”value”
jsmeix
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'tail -n1' to get only the last value if there are more than one
and because getting values from sysconfig files is like sourcing
a shell script it is the last setting that matters, see
c291991#commitcomment-19500870
and
#1038
Cf.
http://stackoverflow.com/questions/2871930/how-to-retrieve-value-from-etc-sysconfig-in-python
that reads (excerpt):
source /etc/sysconfig/FOO
echo $MY_VALUE
and
http://ftp.novell.hu/pub/mirrors/ftp.novell.com/forge/library/SUSE%20Package%20Conventions/spc_sysconfig.html
that reads (excerpts):
The configuration is easily readable by shell scripts
The sysconfig files are plain text files.
The setting is defined by pairs {VARIABLE,value} the following way,
like shell variables:
VARIABLE=”value”