Skip remount sync when systemd is used (issue1097) #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are no furious objections I will merge it soon... |
|
@jsmeix looks clean - thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remounting all what is mounted below /mnt/local
with sync option is no longer needed when systemd is used
because when systemd is used reboot, halt, poweroff,
and shutdown are replaced by scripts that do umount
plus sync to safely shut down the recovery system,
see #1011
and #1097
Furthermore remounting with sync option could become
in practice a major annoyance because it makes writing
anything below /mnt/local basically unusable slow,
see #1097