Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bareos support: add missing directory /var/run/bareos in recovery system #1148

Merged
merged 1 commit into from Jan 3, 2017
Merged

Bareos support: add missing directory /var/run/bareos in recovery system #1148

merged 1 commit into from Jan 3, 2017

Conversation

dl5rcw
Copy link

@dl5rcw dl5rcw commented Jan 3, 2017

we are using rear + bareos in our data center.
executing a test recovery revealed that bareos was requesting /var/run/bareos as a system's directory to exist. We've added it to the skel and it works now. We like to share this improvement.

@jsmeix jsmeix added the bug The code does not do what it is meant to do label Jan 3, 2017
@jsmeix
Copy link
Member

jsmeix commented Jan 3, 2017

@dl5rcw
what Bareos version do you use?
I am not a Bareos user but I think ReaR has worked with
some older Bareos versions without the /var/run/bareos
directory in the ReaR recovery system.

According to
https://github.com/rear/rear/pull/1148/files
you added not only a
usr/share/rear/skel/BAREOS/var/run/bareos
directory but a
usr/share/rear/skel/BAREOS/var/run/bareos/.gitignore
file.
I assume it also works this way but I think
this is not exactly what you intended.

@jsmeix
Copy link
Member

jsmeix commented Jan 3, 2017

See also issues with newer Bareos version like
#1077
and
#1117
and
#1122

@jsmeix jsmeix changed the title add missing directory Bareos support: add missing directory /var/run/bareos in recovery system Jan 3, 2017
@dl5rcw
Copy link
Author

dl5rcw commented Jan 3, 2017

I am using Bareos obelix-dir 16.2.2 (01May16) compiled from source on all machines.
Adding an empty directory to git repo failed. I inserted the .gitignore file alike the empty directory https://github.com/rear/rear/tree/master/usr/share/rear/skel/BAREOS/etc/bareos

@gdha
Copy link
Member

gdha commented Jan 3, 2017

@dl5rcw Indeed empty directories do require a .gitignore file to be accepted by git. OK for me to accept.

@gdha gdha self-assigned this Jan 3, 2017
@gdha gdha added this to the Rear v2.00 milestone Jan 3, 2017
@gdha gdha merged commit 4e846d2 into rear:master Jan 3, 2017
@jsmeix
Copy link
Member

jsmeix commented Jan 3, 2017

I even found the explanation about empty directories and git at
http://stackoverflow.com/questions/115983/how-can-i-add-an-empty-directory-to-a-git-repository

@gdha
I see ReaR mostly has empty directories
with a .gitignore file that contains

*
!.gitignore

which guarantees that the directory remains empty because
this way git ignores all files except the .gitignore file
but
those .gitignore files are empty
usr/share/rear/skel/NBU/usr/openv/var/vnetd/.gitignore
usr/share/rear/skel/NSR/usr/lib/nsr/.gitignore
usr/share/rear/skel/default/run/lvm/.gitignore
usr/share/rear/skel/default/run/resolvconf/.gitignore
usr/share/rear/skel/default/run/systemd/journal/syslog/.gitignore
usr/share/rear/skel/default/run/udev/.gitignore
usr/share/rear/skel/default/usr/include/.gitignore
usr/share/rear/skel/default/usr/lib/udev/.gitignore
usr/share/rear/skel/default/var/lib/nfs/statd/.gitignore
usr/share/rear/skel/default/var/lock/lockdev/.gitignore
usr/share/rear/skel/default/var/lock/lvm/.gitignore
usr/share/rear/skel/default/var/run/systemd/generator/.gitignore
usr/share/rear/skel/default/var/run/systemd/journal/.gitignore

Should I fix the empty .gitignore files?
(The directories where they are are empty.)

@gdha
Copy link
Member

gdha commented Jan 3, 2017 via email

@jsmeix jsmeix added the external tool The issue depends on other software e.g. third-party backup tools. label Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants