Adapted to Bareos new (since 16.2) configuration schema. Fixes #1077 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding default.conf and BAREOS_CLIENT="`hostname -s`-fd" We have in default.conf HOSTNAME="$( hostname -s 2>/dev/null || uname -n | cut -d. -f1 )" I think this one is better (more fail safe because it has a fallback). Furthermore according to Use $( COMMAND ) instead of backticks `COMMAND` Therefore I suggest to use this form in default.conf and BAREOS_CLIENT="$HOSTNAME-fd" |
jsmeix
added
bug
gdha
requested changes
Jan 17, 2017
gdha
approved these changes
Jan 17, 2017
|
changed to $HOSTNAME as suggested. |
This was referenced Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with old and new configuration layout on Centos7 in our CI environment.