New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SUSE_LINUX as OS_VENDOR on all SUSE systems. #1241
Use SUSE_LINUX as OS_VENDOR on all SUSE systems. #1241
Conversation
I like to merge it soon because I think it is a good first step |
Ok go ahead with the pull request
Gratien
Verstuurd vanaf mijn iPhone
… Op 15 mrt. 2017 om 10:48 heeft Johannes Meixner ***@***.***> het volgende geschreven:
I like to merge it soon because I think it is a good first step
into the right direction and if somthing fails I will fix it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…e automatically added comments in /etc/rear/os.conf in the recovery system
Tested on SLES12 SP2 where it works for me. |
Triggered by #1311 I looked again at this and realized what (IMHO) happened here: OS_VENDOR and OS_MASTER_VENDOR should indeed never be the same. Apparently on some SUSE distros this happened, setting both to SUSE_LINUX. While the current fix in this PR works it actually goes against the original concept of the Maybe with Fedora/RHEL/CentOS this works better because they are more consistent in the output of |
The code of SetOSVendorAndVersion() somehow I implemented that behaviour now also for SUSE. As a second step all SUSE_LINUX directories could now be It never happened in real usage that OS_VENDOR and When OS_VENDOR and OS_MASTER_VENDOR should According to the code of SetOSVendorAndVersion() case "$OS_VENDOR_VERSION" in (*Oracle*|*CentOS*|*FedoraCore*|*RedHat*|*Scientific*) OS_MASTER_VENDOR="Fedora" I don't think Fedora/RHEL/CentOS are consistent |
+1 for adding a test to prevent running with OS_VENDOR and OS_MASTER_VENDOR set to the same. Fedora-based distros so far (as I have seen) are much more consistent with regard to their And yes, I would strongly suggest to actually use OS_MASTER_VENDOR for SUSE and set OS_VENDOR to something that differentiates between the different SUSE flavors. |
Clean up the SetOSVendorAndVersion function a bit.
In particular set SUSE_LINUX as OS_VENDOR
on all SUSE systems but do not set OS_MASTER_VENDOR
same as OS_VENDOR because then scripts in
a .../$OS_VENDOR/... or .../$OS_MASTER_VENDOR/...
sub-directory would get sourced twice by
the (buggy?) SourceStage function.
This pull request is triggered by
#1171 (comment)
and it is also related to
#1214 (comment)