New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected bad test for UEFI partition check inside /boot. #1257
Conversation
@gozora To my knowledge this was already fixed - did you forgot a |
Hello @gdha, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to see the same test:
test "$( find /boot -maxdepth 1 -iname efi -type d )" || return
as in script usr/share/rear/prep/default/310_include_uefi_tools.sh
@gozora Could you - by the way - have a look at my comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
42d1c4c
it is o.k. for me.
Honestly? I really don't know which approach would be better :-(. I'll try to focus on this part of code during my testing and maybe to find out what would be better behavior ... V. |
How unfortunate - now I can no longer merge it ;-) @gdha |
Today I've accidentally found a small regression that can basically avoid ReaR to correctly setting USING_UEFI_BOOTLOADER=1.
With old code:
If efi directory is found inside /boot 320_include_uefi_env.sh would prematurely return.