Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipath device mapping #1315

Merged
merged 6 commits into from Apr 21, 2017
Merged

Multipath device mapping #1315

merged 6 commits into from Apr 21, 2017

Conversation

schabrolles
Copy link
Member

Creating a set of rules based on OS type (RedHat, Suse) to set the suffix used between multipath disk name and partition number:

  • RHEL < 7 => p
  • RHEL >= 7 => ""
  • SUSE < 12 => _part
  • SUSE > 12 => -part

Can easily be updated with other Linux distro

@gdha
Copy link
Member

gdha commented Apr 18, 2017

@schabrolles See also #1302 - is this covered as well?

@gdha gdha requested review from gdha, jsmeix and gozora April 18, 2017 13:05
@gdha gdha self-assigned this Apr 18, 2017
@gdha gdha added the enhancement Adaptions and new features label Apr 18, 2017
@gdha gdha added this to the ReaR v2.1 milestone Apr 18, 2017
@gdha gdha mentioned this pull request Apr 18, 2017
Merged
@schabrolles schabrolles mentioned this pull request Apr 18, 2017
Merged
@schabrolles
Copy link
Member Author

@gdha #1302 is currently not covered by this pull request.
I only cover the specificities of device in /dev/mapper

I had a look to #1302, I think it should be ok as eMMC or NVMe are not multipathed.

jsmeix
jsmeix approved these changes Apr 19, 2017
View reviewed changes
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot do a meaningful review here
because I do not know sufficiently
about that area.
I simply trust @schabrolles here.

gdha
gdha approved these changes Apr 19, 2017
View reviewed changes
Copy link
Member

@gdha gdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first glance I see no issues, but OTOH there will be issues for sure later on. We have to deal with them when these pop up.

@gdha
Copy link
Member

gdha commented Apr 19, 2017

@schabrolles As no-one objects we approve this pull request. Thank you for your nice contribution that I wanted to do 4 years ago, but the sponsor dropped off and so did I.

@gdha gdha merged commit a549a05 into rear:master Apr 21, 2017
schabrolles added a commit to schabrolles/rear that referenced this pull request Apr 24, 2017
@schabrolles
Add partition prefix "-part" for multipathed device in Ubuntu.
f3244f8 
 - Like rear#1315, add "-part" as multipath prefix for ubuntu.
schabrolles added a commit to schabrolles/rear that referenced this pull request Apr 24, 2017
@schabrolles
Add partition prefix "-part" for multipathed device in Ubuntu.
eb8c841 
 - Like rear#1315, add "-part" as multipath prefix for ubuntu.
@schabrolles schabrolles mentioned this pull request Apr 24, 2017
Merged
@schabrolles schabrolles deleted the multipath_mapping branch May 4, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdha gdha gdha approved these changes

@jsmeix jsmeix jsmeix approved these changes

@gozora gozora gozora approved these changes

Assignees

@gdha gdha

Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Milestone
ReaR v2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schabrolles @gdha @jsmeix @gozora