New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try wipefs and use dd as fallback (issue1327 and related to issue799) #1336
Try wipefs and use dd as fallback (issue1327 and related to issue799) #1336
Conversation
@gdha @gozora If there are no furious objections I will "just merge" it soon But it follows the traditional Unix philosopy "Worse is better" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According my brief check $has_wipefs will always be true.
Can't we just completely get rid of it together with all test "$has_wipefs"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite my previous comment I don't have any big objections ;-).
@gozora |
I removed the "cleanup" label from this pull request |
…ssue1327_and_pullrequest1336 Cleanup wipefs code, see #1336 (comment) which is related to #1327
Hereby I implemented basically my proposal
#1327 (comment)
and additionally now dd is used as generic fallback in any case.
I tested it on SLE12 with wipefs in the recovery system
and also without wipefs in the recovery system
(i.e. for me also the dd fallback works).
Details:
With wipefs in the recovery system
I get in diskrestore.sh
and in the "rear -d -D recover" log file
Without wipefs in the recovery system
I get in diskrestore.sh
and in the "rear -d -D recover" log file