Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Relax-and-Recover to use duplicity and duply as backup methods #135

Merged
merged 4 commits into from Jul 26, 2012

Conversation

thumm
Copy link
Contributor

@thumm thumm commented Jul 26, 2012

Duplicity is a backup tool that supports encrypted incremental backup to local or remote storage. Duply as a shell frontend to duplicity simplifies backup tasks.

This patchset adds two additional backup targets to ReaR to use duplicity and duply while recovering a system.

@jhoekx
Copy link
Contributor

jhoekx commented Jul 26, 2012

Ok, looks simple and good!

One question:
is it necessary to have two separate methods? As far as I could see the code in DUPLICITY is a subset of DUPLY, the only difference being the additional binary? Can't you merge them into one and copy duply only when it's on the system.

Something like this:

REQUIRED_PROGS=(
"${REQUIRED_PROGS[@]}"
gpg
duplicity
python2.6
)
PROGS=(
"${PROGS[@]}"
duply
)

That would mean you need at least duplicity and duply will be copied when available.

@thumm
Copy link
Contributor Author

thumm commented Jul 26, 2012

Beside the binaries duply needs the files in the directories
/etc/duply
/root/.duply
to be part of the recovery image. Is it possible to extend COPY_AS_IS
with paths which do not exist? If this is the case it's not necessaray
to have two separate methods.

@jhoekx
Copy link
Contributor

jhoekx commented Jul 26, 2012

Yes, COPY_AS_IS does (or should) not complain when listed files are missing. For example, I have no /etc/termcap and I can still make a backup.

@thumm
Copy link
Contributor Author

thumm commented Jul 26, 2012

Ok, pull request is updated

@jhoekx
Copy link
Contributor

jhoekx commented Jul 26, 2012

Good.

Another question: what is build-stamp? You remove it in the makefile, but I have never seen it...

@thumm
Copy link
Contributor Author

thumm commented Jul 26, 2012

The file is generated if you build a debian package with the make target deb
make deb

I use this target because I always install rear on a server as a debian
package.

jhoekx added a commit that referenced this pull request Jul 26, 2012
Extend ReaR to use duplicity and duply as backup methods. Use BACKUP=DUPLICITY to enable.

Update Makefile to clean debian packaging leftovers.
@jhoekx jhoekx merged commit add2c8b into rear:master Jul 26, 2012
@jhoekx
Copy link
Contributor

jhoekx commented Jul 26, 2012

Ok, merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants