Fix UEFI tools integration (should address issues in #1477, #1478) #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on Ubuntu 16.04.3 LTS with UEFI. BIOS-only tests outstanding. |
gdha
approved these changes
Sep 11, 2017
schlomo
approved these changes
Sep 11, 2017
| @@ -1,19 +1,10 @@ | |||
| # | |||
| # 310_include_uefi_tools.sh | |||
| # 330_include_uefi_tools.sh | |||
There was a problem hiding this comment.
Do we need to name the script in the script? If nobody sees a reason then let's remove this.
There was a problem hiding this comment.
I don't see a necessity. Inherited from 6e05b6f
|
Just for my understanding, this PR supersedes #1477, right ? |
|
Yes, it does. |
jsmeix
approved these changes
Sep 12, 2017
|
@gozora |
jsmeix
added
bug
|
I confirm that it fixes #1478 for me and looks cleaner than anything else. |
|
Thanks everyone! |
|
@OliverO2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrates UEFI tools on demand as determined by
320_include_uefi_env.sh.It avoids replicating UEFI tests already done in
320_include_uefi_env.shand just relies on a correctly set$USING_UEFI_BOOTLOADERvariable. For such variable to be set correctly,310_include_uefi_tools.shis renamed to330_include_uefi_tools.sh.