Avoid log messages about multiple disk partitions with identical name #1483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Original gpt disk partitions may be unnamed. As parted requires a name for each gpt partition, ReaR currently supplies "rear-noname" for originally unnamed partitions. This leads to systemd log messages during
rear recover
and in boot logs:Solution:
To supply unique names for unnamed partitions, just use the basename of the partition's device path, e.g. sda1, sda2, ...
The suggested change also strips unnecessary quotes from parted invocations.
Tested on Ubuntu 16.04.3 LTS (gpt only).