New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid recreation of non-existing btrfs subvolumes (fix #1496) #1499
Avoid recreation of non-existing btrfs subvolumes (fix #1496) #1499
Conversation
@OliverO2 I only wonder about the reason behind |
Yes, I had considered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine now.
If there are no objections I will merge it soon... |
@jsmeix Over here, disklayout.conf contains 268 lines, 213 of them (86%) are What about just putting just a comment about the number of snapshot volumes encountered in disklayout.conf and put the snapshot paths in the log file only? |
@OliverO2 In your case according to your valuable explanation in I suggest to provide another config variable so that the EXCLUDE_RECREATE=( "${EXCLUDE_RECREATE[@]}" "btrfssnapshotsubvol:all" ) where a special qualifier like 'all' could mean that all btrfs I only like that by default btrfs snapshot subvolumes |
I have tested that a ReaR recovery still works |
This PR makes sure that a btrfs subvolume actually exists before trying to recreate it.
See #1496.