New network script generator (60-network-devices.sh) #1574

rmetrich · 2017-11-14T14:42:35Z

This work is a solution for Issue #1561.

It consists in a full rewrite of the 310_network_devices.sh script generating network interfaces for use during the ReaR recovery early boot.
It also handles corner cases/odd setups that can be found from time to time, typically when the administrator uses bonding + bridges + vlans as well as teaming.
With that new code, adding new configurations will be very easy in the future.

I also added interface mapping code to the corresponding 350_routing.sh script generating routes.

In the tests/ directory, you will 2 setups that I used to verify the network generation code. It covers quite a lot of setups found.

jsmeix · 2017-11-15T13:38:56Z

@rmetrich
many thanks for your substantial work!

According to
#1561 (comment)
I set it to "ReaR 2.4"

@gdha @gozora
I dared to set you as reviewers here. I would very much
appreciate it if you could have a look if there are perhaps
immediately visible possible issues with the new code.
Many thanks in advance!

gdha

The change is code is quite huge, and therefore, not easy to decide if everything is ok or not.
I suppose the first tests will tell us very quickly. On first sight the code looks clean and well written with good documentation. A job well done (I should do that more often:)

gdha · 2017-11-15T13:59:50Z

The only thing that bothers me are the Unit Tests - nice to have but do they belong in the code? There are pros and contras for it. We can leave it here for the moment

jsmeix · 2017-11-15T14:01:30Z

@gdha
does your approval mean that from your current point of view
we could even merge it into ReaR 2.3 or should we wait in any
case and merge it directly after ReaR 2.3 was released (to get
it tested by ReaR users until ReaR 2.4 will be released).

gdha · 2017-11-15T14:06:20Z

@jsmeix I would prefer that we release 2.3 first and then do the merge as then we will have plenty of time to test the code base.

rmetrich · 2017-11-15T14:13:15Z

@gdha I put the unit tests here just for reference.
Since network configurations can be very tricky, I believe having unit tests may help in the future, making sure nothing breaks.

jsmeix · 2017-11-15T14:13:35Z

I also prefer to release ReaR 2.3 first to stay on the safe side.

gozora · 2017-11-15T16:51:12Z

@rmetrich I can't tell nothing less then IMPRESSIVE! ;-)

As i'm not much of a "code reader", I'd need to test this directly by clone and run ...
I will do that over this weekend and you guys know how it went ...

V.

gozora

I've run several tests, and for me this PR works sufficiently well.

V.

rmetrich · 2017-11-18T13:25:03Z

"Sufficiently", did you find issues? Renaud. Sent from my phone. Le 18 nov. 2017 2:05 PM, "Vladimir Gozora" <notifications@github.com> a écrit :

…

***@***.**** approved this pull request. I've run several tests, and for me this PR works sufficiently well. V. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1574 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHBc3Ksen6YqZN29dNnc1D_DZ9K87tCks5s3tX8gaJpZM4QdcWP> .

gozora · 2017-11-18T13:32:09Z

:-), no but I never actually used all those fancy ReaRs networking options and if my network is not up properly, I just configure it manually ;-).
I've found some problems with 320_migrate_network_configuration_files.sh where I got following error:

2017-11-18 11:21:39.162298984 SED_SCRIPT: ';s/08:00:27:2a:4f:0a/08:00:27:76:fa:e7/g;s/eth0/eth0
eth1
bond0
vlan100@bond0/g;s/08:00:27:2A:4F:0A/08:00:27:76:FA:E7/g;s/Eth0/eth0
eth1
bond0
vlan100@bond0/g;s/08:00:27:e8:3e:07/08:00:27:0f:00:78/g;s/08:00:27:E8:3E:07/08:00:27:0F:00:78/g'
sed: -e expression #1, char 52: unterminated `s' command

I'm pretty sure that this is not related to your work though.

I've tested your PR in vlan over bonded device and it worked well, and as I did not had time to test it much further I've choose word "Sufficiently" hope you don't mind ;-)

V.

hpannenb · 2017-11-27T18:30:19Z

@rmetrich At a RHEL6.5 server with several bridges and bonding interfaces here the ip link command mentions an

bridge: unkown command "stp_state"?

The version in use is "ip utility, iproute2-ss091226".
During recovery the created script /etc/scripts/system-setup.d/60-network-devices.sh thus will not create the bridges here.

rmetrich · 2017-11-27T19:17:44Z

@hpannenb Thanks for reporting. I'll test on RHEL6 and adjust.

rmetrich · 2017-11-29T10:55:29Z

@hpannenb Please try the latest code.
I reworked many things for "ancient" releases.

hpannenb · 2017-11-30T15:04:37Z

@rmetrich I tested with Your pull request #1605 and on the RHEL6 Server the interfaces, bonding and bridges were created as supposed to. Thanks for Your coding effort.

rmetrich · 2017-11-30T15:18:23Z

@hpannenb Thanks for feedback. I initially didn't test on RHEL6 because we (Red Hat) do not ship ReaR 2.x on RHEL6 ...

gdha · 2018-01-09T10:06:57Z

@rmetrich Could you fix the conflicts then we are able to merge it without issues?

…eam' and 'physdev' - Removed current teaming code - Have routes use interface mapping - Added explanations

- Adapt search for lower interfaces when no 'lower_*' symlink exists (RHEL6) - Always set device for bonding using 'echo "+dev" > .../bond/bonding/slaves' - Detect support for 'master' in 'ip link' (no support in RHEL6) - Replace 'readlink -f' by 'readlink -e' - Use 'brctl' when 'ip link' doesn't support 'bridge' type (RHEL6) - Use function 'resolve' to wrap 'readlink' when it doesn't support more than 1 filename (RHEL6)

rmetrich · 2018-01-09T10:50:18Z

@gdha Done!

gdha · 2018-01-16T16:45:27Z

@jsmeix can we merge it?

jsmeix · 2018-01-17T08:03:03Z

@gdha
yes, we can merge it.

jsmeix · 2018-01-17T08:09:17Z

@rmetrich
many thanks for your substantial contribution to ReaR!

jsmeix self-assigned this Nov 15, 2017

jsmeix requested review from gdha and gozora November 15, 2017 13:31

jsmeix added cleanup documentation enhancement Adaptions and new features labels Nov 15, 2017

jsmeix added this to the ReaR v2.4 milestone Nov 15, 2017

gdha approved these changes Nov 15, 2017

View reviewed changes

gdha mentioned this pull request Nov 17, 2017

Add support for Bridge Interfaces #1570

Merged

jsmeix mentioned this pull request Nov 17, 2017

Create a recovery RAW disk #1578

Closed

gozora approved these changes Nov 18, 2017

View reviewed changes

rmetrich force-pushed the NewNetworking branch from 979ba3e to a7919c2 Compare November 28, 2017 19:27

rmetrich changed the title ~~New network script generator (60-network-devices.sh)~~ WIP: New network script generator (60-network-devices.sh) Nov 29, 2017

rmetrich changed the title ~~WIP: New network script generator (60-network-devices.sh)~~ New network script generator (60-network-devices.sh) Nov 30, 2017

New 310_network_devices.sh code handling 'bond', 'bridge', 'vlan', 't…

15567ed

…eam' and 'physdev' - Removed current teaming code - Have routes use interface mapping - Added explanations

rmetrich added 7 commits January 9, 2018 11:33

Setup rear#1 Unit Tests

3f31fae

Setup rear#2 Unit Tests

69ab391

Improved unit test runner & validator

801604a

Replaced 'has_lower_links' and 'iplink_has_bridge' by boolean variables

4c7c548

Coding style

95d1795

Added 'documentation' of SIMPLIFY_BRIDGE and SIMPLIFY_TEAM

1c42620

rmetrich force-pushed the NewNetworking branch from dc31316 to 1c42620 Compare January 9, 2018 10:47

jsmeix merged commit 0293785 into rear:master Jan 17, 2018

jsmeix added the fixed / solved / done label Jan 17, 2018

jsmeix mentioned this pull request Jan 17, 2018

Teaming interface support is very limited #1561

Closed

jsmeix mentioned this pull request May 2, 2018

IBM Power8 (PPC) network bond issue with non-sequential bond names #1789

Closed

rmetrich deleted the NewNetworking branch June 6, 2018 20:09

jsmeix mentioned this pull request Jan 2, 2023

Rescue/recovery networking does not work with IPv6 only NICs. #2902

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New network script generator (60-network-devices.sh) #1574

New network script generator (60-network-devices.sh) #1574

rmetrich commented Nov 14, 2017

jsmeix commented Nov 15, 2017

gdha left a comment

gdha commented Nov 15, 2017

jsmeix commented Nov 15, 2017 •

edited

gdha commented Nov 15, 2017

rmetrich commented Nov 15, 2017

jsmeix commented Nov 15, 2017

gozora commented Nov 15, 2017

gozora left a comment

rmetrich commented Nov 18, 2017 via email

gozora commented Nov 18, 2017

hpannenb commented Nov 27, 2017

rmetrich commented Nov 27, 2017

rmetrich commented Nov 29, 2017

hpannenb commented Nov 30, 2017

rmetrich commented Nov 30, 2017

gdha commented Jan 9, 2018

rmetrich commented Jan 9, 2018

gdha commented Jan 16, 2018

jsmeix commented Jan 17, 2018

jsmeix commented Jan 17, 2018

New network script generator (60-network-devices.sh) #1574

New network script generator (60-network-devices.sh) #1574

Conversation

rmetrich commented Nov 14, 2017

jsmeix commented Nov 15, 2017

gdha left a comment

Choose a reason for hiding this comment

gdha commented Nov 15, 2017

jsmeix commented Nov 15, 2017 • edited

gdha commented Nov 15, 2017

rmetrich commented Nov 15, 2017

jsmeix commented Nov 15, 2017

gozora commented Nov 15, 2017

gozora left a comment

Choose a reason for hiding this comment

rmetrich commented Nov 18, 2017 via email

gozora commented Nov 18, 2017

hpannenb commented Nov 27, 2017

rmetrich commented Nov 27, 2017

rmetrich commented Nov 29, 2017

hpannenb commented Nov 30, 2017

rmetrich commented Nov 30, 2017

gdha commented Jan 9, 2018

rmetrich commented Jan 9, 2018

gdha commented Jan 16, 2018

jsmeix commented Jan 17, 2018

jsmeix commented Jan 17, 2018

jsmeix commented Nov 15, 2017 •

edited