Make ssh key generation in recovery system also work for SysVinit #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmeix
added
enhancement
|
Because it works well for me both on SLES11 and SLES12 |
OliverO2
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
Looks good to me.
For an explanation of inittab and systemd.services in this context see #1512 (comment).
| @@ -1,16 +1,27 @@ | |||
| #!/bin/bash | |||
| # check inittab for "ssh:23:respawn:/bin/sshd -D" | |||
| # Check /etc/inittab for "ssh:23:respawn:..." which means sshd should be started | |||
| # (that entry is written by rescue/default/500_ssh.sh if sshd should be started): | |||
| if grep -q '^ssh:' /etc/inittab ; then | |||
There was a problem hiding this comment.
A bit strange to have a systemd-based initialization depend on init-based stuff, but also reflected in usr/share/rear/skel/default/usr/lib/systemd/system/sshd.service. Maybe something for a future cleanup.
There was a problem hiding this comment.
There is so much to clean up in ReaR, even crucial things, e.g.
#1603 (comment)
|
@OliverO2 |
jsmeix
deleted the
make_ssh_key_generation_also_work_for_SysVinit_issue1512
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
#1512 (comment)
and subsequent comments, in particular see
#1512 (comment)
but I decided to keep the
in skel/default/etc/scripts/run-sshd
because as far as I understand it a
"ssh:23:respawn:..." entry in /etc/inittab is written by
rescue/default/500_ssh.sh only if sshd should be started.