Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in: if test -n "btrfs_subvolume_path" ; then ? #1650

Merged
merged 1 commit into from Dec 18, 2017

Conversation

ProBackup-nl
Copy link
Contributor

The might be a typo in https://github.com/rear/rear/blob/master/usr/share/rear/layout/save/GNU/Linux/230_filesystem_layout.sh#L397

if test -n "btrfs_subvolume_path" ; then
if test -n "$btrfs_subvolume_path" ; then
Or not?

if test -n "$btrfs_subvolume_path" ; then
Or not?
@jsmeix jsmeix self-assigned this Dec 18, 2017
@jsmeix jsmeix added the bug The code does not do what it is meant to do label Dec 18, 2017
@jsmeix jsmeix added this to the ReaR v2.3 milestone Dec 18, 2017
@jsmeix jsmeix merged commit 68583bf into rear:master Dec 18, 2017
@jsmeix
Copy link
Member

jsmeix commented Dec 18, 2017

@ProBackup-nl
many thanks for finding this bug!
I assume it did not had real bad effects in practice
because on SLE12 systems where that code matters
that special 'chattr' stuff for certain btrfs subvolumes
had always worked for me on my test systems where
I got in var/lib/rear/layout/disklayout.conf

# Mounted btrfs subvolumes that have the 'no copy on write' attribute set.
# Format: btrfsnocopyonwrite 
btrfsnocopyonwrite @/var/lib/libvirt/images
btrfsnocopyonwrite @/var/lib/pgsql
btrfsnocopyonwrite @/var/lib/mariadb
btrfsnocopyonwrite @/var/lib/mysql

@jsmeix
Copy link
Member

jsmeix commented Dec 19, 2017

Verified that it still works on SLES12 with its btrfs default structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants