Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmpfs/ramdrive -> test -e /etc/rear-release #1663

Merged
merged 1 commit into from Jan 26, 2018
Merged

Conversation

ProBackup-nl
Copy link
Contributor

Doc seems to incorrectly state that the code would check for running from tmpfs or ramdisk. The actual check in code that I can find is much simpler: "test -e /etc/rear-release" at https://github.com/rear/rear/blob/master/usr/sbin/rear
Better reflect the actual behavior in documentation.

Doc seems to incorrectly state that the code would check for running from tmpfs or ramdisk. The actual check in code that I can find is much simpler: "test -e /etc/rear-release" at <https://github.com/rear/rear/blob/master/usr/sbin/rear>
Better reflect the actual behavior in documentation.
@jsmeix jsmeix requested review from schlomo and gdha January 2, 2018 14:41
@jsmeix jsmeix added this to the ReaR v2.4 milestone Jan 2, 2018
@jsmeix
Copy link
Member

jsmeix commented Jan 2, 2018

@schlomo @gdha
in
https://github.com/rear/rear/blob/master/doc/user-guide/09-design-concepts.adoc
I don't know what the "demo" recovery workflow should be and/or
how a "demo" recovery workflow could be started manually.

According to the code in
init/default/050_check_rear_recover_mode.sh
any "rear recover" command would be aborted
unless /etc/rear-release exists.

The part about the "demo" recovery workflow in
doc/user-guide/09-design-concepts.adoc
exists since that file had been created as
doc/relax-recover-concept.txt
on Jun 14 2011 via
f4fae8a

@jsmeix
Copy link
Member

jsmeix commented Jan 2, 2018

I think the whole paragraph

The recovery workflow is triggered by the fact that
the root filesystem is mounted in a ram disk or tmpfs.
Alternatively a "demo" recovery workflow can be
started manually. This will simply recover all data into
a subdirectory and not touch the hard disks (Phase 2).

might be deleted because /etc/rear-release is an implementation detail
that does not need to be documented here and I guess that "Phase 2"
means that the "demo" recovery workflow was meant to be
implemented in the future but it never happened.

@schlomo
Copy link
Member

schlomo commented Jan 2, 2018

I am not aware of a demo recovery workflow and git grep doesn't find anything. So probably a good idea to remove this part of the documentation till somebody implements such a workflow.

@gdha gdha self-assigned this Jan 2, 2018
@gdha gdha merged commit 145f166 into rear:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants