New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the os.conf creation in the rear.spec file #1713
Conversation
…on SetOSVendorAndVersion the proper detection of RedHatEnterpriseServer. Added new script usr/share/rear/init/default/005_verify_os_conf.sh to create the os.conf if it did not exist yet - issue #1639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From plain looking at the code
it looks good to me.
@gdha |
@jsmeix os.conf is important during the recover phase as we cannot trust that the SetOSVendorAndVersion() function will work properly. |
Yes, but why is /etc/rear/os.conf autocreated in the original sytem? Why not only autocreate a $ROOTFS_DIR/etc/rear/os.conf in the recovery system In general I do not like it when any "rear WORKFOLW" automatically |
@gdha this is old stuff, but I have a very important question: What needs the The reason I'm asking are two problems I encounter:
So I'd like to find out if I can move it to the rescue system only. Or maybe we actually don't need it any more because |
See also |
Remove the os.conf creation in the rear.spec file and fixed in function SetOSVendorAndVersion the proper detection of RedHatEnterpriseServer. Added new script usr/share/rear/init/default/005_verify_os_conf.sh to create the os.conf if it did not exist yet - issue #1639