Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1701: Use a fallback to get interface state using the 'carrier' status #1719

Merged
merged 1 commit into from Feb 8, 2018
Merged

Issue #1701: Use a fallback to get interface state using the 'carrier' status #1719

merged 1 commit into from Feb 8, 2018

Conversation

rmetrich
Copy link
Contributor

Since some network drivers do not set the operstate value to down or up, we can fallback to using the carrier value:

  • failing to read the value means interface is administratively down
  • reading 0 means down
  • reading 1 means up

jsmeix
jsmeix approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From plain looking at the code
it looks o.k. to me.

@jsmeix jsmeix requested a review from gdha February 7, 2018 12:43
@jsmeix jsmeix self-assigned this Feb 7, 2018
@jsmeix jsmeix added the enhancement Adaptions and new features label Feb 7, 2018
@jsmeix jsmeix added this to the ReaR v2.4 milestone Feb 7, 2018
@jsmeix
Copy link
Member

jsmeix commented Feb 7, 2018

@gdha
if you do not object, I would like to merge it tomorrorw.

@jsmeix jsmeix mentioned this pull request Feb 7, 2018
Closed
@jsmeix jsmeix merged commit af777ec into rear:master Feb 8, 2018
@jsmeix jsmeix mentioned this pull request May 2, 2018
Closed
@rmetrich rmetrich deleted the Issue_1701 branch June 6, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdha gdha gdha approved these changes

@jsmeix jsmeix jsmeix approved these changes

Assignees

@jsmeix jsmeix

Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Milestone
ReaR v2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmetrich @jsmeix @gdha