Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaR with Borg back end to USB. #1730

Merged
merged 6 commits into from Feb 20, 2018
Merged

ReaR with Borg back end to USB. #1730

merged 6 commits into from Feb 20, 2018

Conversation

gozora
Copy link
Member

@gozora gozora commented Feb 12, 2018

Pull Request Details:
  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL): http://lists.relax-and-recover.org/pipermail/rear-users/2018-February/003518.html

  • How was this pull request tested?
    Run of complete backup / restore on Fedora 26 (Legacy boot) with borg 1.1.2 (Borg binaries generated with pyinstaller) using Relax-and-Recover 2.3 / Git
    Regression test of Borg -> ISO with same OS / Borg / ReaR versions.

  • Brief description of the changes in this pull request:
    This PR implements possibility to run ReaR with Borg back end and store backup on USB disk.

but only report that something went wrong to log file and to
user terminal.
This commit addresses issue rear#1702.
repo_dev was renamed to more meaningful borg_dst_dev.
BUILD_DIR/borg_backup leftovers replaced by borg_dst_dev.
Code for mount / unmount USB device in backup section
moved to separate scripts.
@gozora gozora self-assigned this Feb 12, 2018
@gozora gozora added the enhancement Adaptions and new features label Feb 12, 2018
@gozora gozora added this to the ReaR v2.4 milestone Feb 12, 2018

LogPrintIfError "Error was reported during Borg restore"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change addresses #1702

- Install Borg backup (https://borgbackup.readthedocs.io/en/stable/installation.html).

IMPORTANT: We strongly recommend to use Borg standalone binary (https://github.com/borgbackup/borg/releases) as it includes all necessities for Borg operations.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation update (whole IMPORTANT block) addresses part of #1727

Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From plain looking at the code
all looks perfectly fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants