New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not print each files restores by TSM in main output #1797
Conversation
- improve ReaR output readability - redirect TSM output to external logfile
# Regarding usage of '0<&6 1>&7 2>&8' see "What to do with stdin, stdout, and stderr" in https://github.com/rear/rear/wiki/Coding-Style | ||
LC_ALL=$LANG_RECOVER dsmc restore "$filespace" "$TARGET_FS_ROOT/$filespace" -subdir=yes -replace=all -tapeprompt=no "${TSM_DSMC_RESTORE_OPTIONS[@]}" 0<&6 1>&7 2>&8 | ||
LC_ALL=$LANG_RECOVER dsmc restore "$filespace" "$TARGET_FS_ROOT/$filespace" -subdir=yes -replace=all -tapeprompt=no "${TSM_DSMC_RESTORE_OPTIONS[@]}" 0<&6 1>"$TMP_DIR/TSM_restore.log" 2>&8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In usr/share/rear/restore/NETFS/default/400_restore_backup.sh we have
( case "$BACKUP_PROG" in (tar) ... esac >"${TMP_DIR}/${BACKUP_PROG_ARCHIVE}-restore.log"
which results a /tmp/rear.XXX/tmp/backup-restore.log
file
so that I suggest to use same kind of file name also for TSM i.e.
... 1>"$TMP_DIR/TSM-restore.log" ...
or perhaps even instead of the hardcoded TSM
some kind of BACKUP_PROG_ARCHIVE equivalent for TSM
if such a variable exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Perhaps use a backup restore log file name
of the form ...-restore.log
so that ist is same
as for a ReaR NETFS backup restore.
Right now I noticed that the backup restore log file is not copied Perhaps it is better when in general a backup restore log file |
Now I noticed that a backup restore log file |
@jsmeix, |
@schabrolles |
FYI: |
Relax-and-Recover (ReaR) Pull Request Template
Please fill in the following items before submitting a new pull request:
Pull Request Details:
Type: Enhancement
Impact: Low
Reference to related issue (URL):
How was this pull request tested?
By default, TSM logs every file restored in the main output.
This produces a huge and difficult to read ReaR logfile.
The purpose of this PR is to