Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mods to allow slackware ISO image and udev sda fix #1863

Merged
merged 1 commit into from Jul 17, 2018

Conversation

wdmsde
Copy link
Contributor

@wdmsde wdmsde commented Jul 15, 2018

Pull Request Details:
  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL): N/A

  • How was this pull request tested?
    Tested on laptop running Slackware 14.2 with grub upgraded to v2.02.
    Used "rear -d -D mkrescue" to successfully create a bootable ISO image burned to DVD. Booted ReaR rescue image but did not run recover.

  • Brief description of the changes in this pull request:
    Changed 3 files to add support for Slackware ISO rescue image.

Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From plain looking at the code it looks o.k. to me
because as far as I see there cannot be regressions
for non-Slackware distributions.

@jsmeix jsmeix requested a review from gozora July 16, 2018 07:48
@jsmeix
Copy link
Member

jsmeix commented Jul 16, 2018

@gozora
could you also review it because the changes are about EFI?

@jsmeix jsmeix self-assigned this Jul 16, 2018
@jsmeix jsmeix added the enhancement Adaptions and new features label Jul 16, 2018
@jsmeix jsmeix added this to the ReaR v2.5 milestone Jul 16, 2018
@jsmeix jsmeix merged commit 85ddc86 into rear:master Jul 17, 2018
@jsmeix
Copy link
Member

jsmeix commented Jul 17, 2018

@wdmsde
many thanks for your valuable contributions to ReaR!

By the way, I have a question:
Your #1853 and this one
are about adding Slackware support in case of UEFI booting.
Do you know if ReaR works for Slackware when BIOS is used?

@wdmsde
Copy link
Contributor Author

wdmsde commented Jul 17, 2018 via email

@jsmeix
Copy link
Member

jsmeix commented Jul 17, 2018

@wdmsde
I look forward to a pull request from you
with adaptions to support Slackware also on BIOS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants