Remove overwrite of $HOSTNAME in 400_restore_duplicity.sh #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmeix
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
@Lukey3332
many thanks for your prompt fix and for testing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details:
Type: Enhancement
Impact: Low
Reference to related issue (URL):
400_restore_duplicity.sh does unconditioned 'export HOSTNAME=$(hostname)' #1879
How was this pull request tested?
Via partial restore
Brief description of the changes in this pull request:
This removes the overwriting of $HOSTNAME in 400_restore_duplicity.sh.
Just removing the Line should be enough especially because $HOSTNAME isn't overwritten on Duplicity Backup.