Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove After=syslog.target form dbus.service #1230 #1937

Merged
merged 2 commits into from Oct 25, 2018
Merged

Remove After=syslog.target form dbus.service #1230 #1937

merged 2 commits into from Oct 25, 2018

Conversation

gdha
Copy link
Member

@gdha gdha commented Oct 22, 2018

@gdha gdha added enhancement Adaptions and new features cleanup labels Oct 22, 2018
@gdha gdha added this to the ReaR v2.5 milestone Oct 22, 2018
@gdha gdha self-assigned this Oct 22, 2018
@gdha gdha requested a review from jsmeix October 22, 2018 16:03
@jsmeix jsmeix requested review from a team and removed request for jsmeix October 23, 2018 07:38
@jsmeix
Copy link
Member

jsmeix commented Oct 23, 2018

@gdha
I am afraid I cannot actually review systemd related things because
in practice I had to learn that I know nothing about systemd units setup:
Each time I tried to get any systemd unit setup done things ended in havoc.
Probably systemd is just too complicated for a simple mind like me
or systemd is a too fast moving target for a slow mind like mine ;-)

According to
#1230 (comment)
from Jun 26, 2017 the syslog.target became obsolete by now
so that I wonder if disabling of After=syslog.target may cause
regressions when ReaR is used on an older system were an
older systemd is in use where that target is still needed?
Simply put: Is that change here sufficiently backward compatible?

@rear/contributors
could another ReaR contributor have a look here?

@gdha
Copy link
Member Author

gdha commented Oct 23, 2018

@jsmeix The dbus.service file was created by me 7 years ago for Fedora 16 of 17 (I guess), or equal to RHEL 6 (I think). However, RHEL 6 is still not using systemd so we are on the safe side here.
All more recent Linux distributions are evolved from the old systemd incarnation, so we are good here as well. I'm pretty sure it will not have a negative impact on the start-up of systemd based systems.

@jsmeix
Copy link
Member

jsmeix commented Oct 24, 2018

@gdha
thank you for the explanation.

Because After=syslog.target will get only disabled but not completely removed
we are fully sufficiently on the safe side here because a user of an old systemd
can manually re-enable it again if he needs it in his particular case.

Added comment that points to the matching GitHub pull request where the reason behind is explained.
@gdha gdha merged commit 4597dd9 into rear:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants