New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for carriage return in {local|site|rescue}.conf files #1969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice trick with tr
😄
Currently it tests only site.conf local.conf and rescue.conf source $SHARE_DIR/conf/default.conf perhaps we can assume default.conf is never modified by the user test -r "$CONFIG_DIR/os.conf" && Source "$CONFIG_DIR/os.conf" || true test -r "$CONFIG_DIR/$WORKFLOW.conf" && Source "$CONFIG_DIR/$WORKFLOW.conf" || true I think all *.conf files in $CONFIG_DIR could have been broken by the user |
@schlomo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course I happily approve my own code ;-)
FYI: |
@jsmeix Glad to use your code and as the issue was already closed I decided to add it to rear before we all forgot about it. Anyhow, a big thank you. |
@gdha |
…code_of_source_call_related_to_issue_1965 Now the Source function in lib/framework-functions.sh returns the the return code of its actual work which is the return code of its 'source $source_file' call so that the caller of the Source function can now decide what to do and there is a debug log message when 'source $source_file' results a non-zero return code, see the related issues #1965 and #1969 Additionally the call of apply_bash_flags_and_options_commands in the Source function (where actually only 'set +x' is done to switch off debugscript mode) does no longer output long 'set -x' messages which avoids many big but meaningless debugscript messages in the log.
Type: Enhancement
Impact: Low
Reference to related issue (URL): mkrescue error "cp: cannot stat '/tmp/rear.aaja71UVdjBgWZt/tmp/README': No such file or directory" #1965
How was this pull request tested? locally