Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically exclude $BUILD_DIR from the backup #1993

Merged
merged 1 commit into from Dec 5, 2018

Conversation

rmetrich
Copy link
Contributor

@rmetrich rmetrich commented Dec 4, 2018

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Bug Fix

  • Impact: Normal

  • How was this pull request tested?

    • Tested without export TMPDIR=xxx variable
    • Tested with export TMPDIR=xxx variable
  • Brief description of the changes in this pull request:

Usually $BUILD_DIR hosted on /tmp and hence automatically excluded from the backup.
When specifying $TMPDIR, $BUILD_DIR was not excluded from the backup.

usr/sbin/rear Show resolved Hide resolved
@jsmeix jsmeix added the minor bug An alternative or workaround exists label Dec 4, 2018
@jsmeix jsmeix added this to the ReaR v2.5 milestone Dec 4, 2018
@jsmeix jsmeix self-assigned this Dec 4, 2018
Usually $BUILD_DIR hosted on /tmp and hence automatically excluded from the backup.
When specifying $TMPDIR, $BUILD_DIR was not excluded from the backup.

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From plain looking at the code it looks fine to me.

@jsmeix jsmeix requested a review from a team December 4, 2018 11:44
@jsmeix
Copy link
Member

jsmeix commented Dec 4, 2018

@rear/contributors
if there are no objections I would like to merge it tomorrow.

@jsmeix jsmeix merged commit 429c205 into rear:master Dec 5, 2018
@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2018

@rmetrich
thank you for testing non-standard use cases of ReaR!

@rmetrich
Copy link
Contributor Author

rmetrich commented Dec 5, 2018

@jsmeix It's standard, typically when /tmp has "noexec" flag :-)

@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2018

@rmetrich
it seems it is non-standard on SUSE systems (I never experienced it)
which shows how good it is to also have one from Red Hat here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants