Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$TMP_DIR parent directory was missing before initrd filename variable. #1997

Merged
merged 1 commit into from Dec 5, 2018

Conversation

schabrolles
Copy link
Member

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL):

  • How was this pull request tested?

  • Tested on rhel7 on ppc64le with Boot on ISO
  • Brief description of the changes in this pull request:

Fix an error due to missing $TMP_DIR/ before $REAR_INITRD_FILENAME.
This prevents the ISO to be generated because of initrd cannot be found.

Testing that the recovery system in /tmp/rear.hDXOoQTdilZRyyA/rootfs contains a usable system
Creating recovery/rescue system initramfs/initrd initrd.xz with xz lzma compression
Created initrd.xz with xz lzma compression (42387961 bytes) in 113 seconds
ERROR: No initrd 'initrd.xz'
Some latest log messages since the last called script 800_create_isofs.sh:
  2018-12-05 12:15:56.948288172 Including output/ISO/Linux-ppc64le/800_create_isofs.sh
  2018-12-05 12:15:56.949402740 Copying kernel
  '/boot/vmlinuz-3.10.0-693.2.1.el7.ppc64le' -> '/tmp/rear.hDXOoQTdilZRyyA/tmp/kernel'
Aborting due to an error, check /var/log/rear/rear-rear-rhel-142.log for details
Exiting rear mkbackup (PID 447969) and its descendant processes
Running exit tasks
Terminated

@schabrolles schabrolles self-assigned this Dec 5, 2018
@schabrolles schabrolles added the bug The code does not do what it is meant to do label Dec 5, 2018
@schabrolles schabrolles modified the milestones: ReaR future, ReaR v2.5 Dec 5, 2018
@schabrolles
Copy link
Member Author

We miss this one ... maybe because I mostly use PXE to test ReaR on Power....
If you agree, I would like to merge this one ASAP.

@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2018

I agree to merge this one ASAP.

@schabrolles
many thanks for testing OUTPUT=ISO on PPC64LE!

@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2018

FYI:
Currently I fail to see via my "usual forensics" using
git log -p --follow usr/share/rear/output/ISO/Linux-ppc64le/800_create_isofs.sh
how that could have ever worked or when it became broken again
since #109

I have the dim feeling I may have had messed it up
at the time when I introduced REAR_INITRD_FILENAME?

@schabrolles
Copy link
Member Author

@jsmeix I don't know either how it could have worked before (I'm sure it was working...)
Maybe some script like 800_create_isofs.sh were previously executed inside the $TMP_DIR...

@schabrolles schabrolles merged commit 6ec9075 into rear:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants