Fixed exit in usr/sbin/rear when getopt failed #2022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix
Impact: Normal
How was this pull request tested?
By me on my openSUSE Leap 15.0 system.
Before:
(i.e. the 'dump' workflow is run).
With the fix here:
In the code before in usr/sbin/rear
the
$?
does not contain thegetopt
exit codebut the
readonly
return code which is always zero.The new code
fixes that.
In general using
$?
is problematic, cf. theStopIf...
functions#2013 (comment)