Basic support for EFISTUB booting. #2030
Conversation
| (*p) Disk=${Disk%p} ;; | ||
| (*-part) Disk=${Disk%-part} ;; | ||
| (*_part) Disk=${Disk%_part} ;; | ||
| (*) Log "Unsupported kpartx partition delimiter for $Dev" |
There was a problem hiding this comment.
Isn't an "Unsupported kpartx partition delimiter for $Dev"
perhaps even an error that should be made visible to the user
(without aborting rear recover in its late finalize stage) via
LogPrintError "Unsupported kpartx partition delimiter for $Dev"
?
There was a problem hiding this comment.
Honestly, this was just a copy, paste from usr/share/rear/finalize/Linux-i386/630_run_efibootmgr.sh ;-).
But I can change it to LogPrintError in both files if needed ...
There was a problem hiding this comment.
Fortunately this particular lines of code are not from me :-)
From plain looking at the code in both files
I think it is a real error in both cases.
There was a problem hiding this comment.
Yes, looks like error to me as well...
To have better tracking, I'll open separate PR for this "bug" once #2030 is merged.
| else | ||
| Log "EFI_STUB: Kernel file: $KERNEL_FILE is hosted on vfat filesystem" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Ony a side note:
You could - if you like - simplify it e.g. as
if ERROR_CONDITION ; then
Error "..."
fi
Log "..."
or even
ERROR_CONDITION && Error "..."
Log "..."
There was a problem hiding this comment.
Something like:
[[ "$uefi_fs_type" != "vfat" ]] && Error "EFI_STUB: Kernel file: $KERNEL_FILE is not hosted on vfat filesystem"
Log "EFI_STUB: Kernel file: $KERNEL_FILE is hosted on vfat filesystem"
?
There was a problem hiding this comment.
Yes - but only if you like it - I see such kind of code e.g. in
usr/share/rear/layout/save/GNU/Linux/190_opaldisk_layout.sh
There was a problem hiding this comment.
In this particular case I don't have any real preference, so I'll change it as agreed ...
….conf instead of hidden in code. Simplified condition syntax in prep/GNU/Linux/500_EFISTUB_check_kernel.sh.
|
If there are no further objections, I'll merge this code later today. V. |
Pull Request Details:
Type: New Feature
Impact: Normal
Reference to related issue (URL): Support EFISTUB booting (e.g. on Arch Linux) #1942
How was this pull request tested?
Full backup restore on Arch Linux configured for EFISTUB booting.
Migration from GRUB2 to EFISTUB on SLES2 SP2.
Brief description of the changes in this pull request:
This patch enables basic support in ReaR for systems setup to boot using EFISTUB.