Do not patch $TARGET_FS_ROOT/etc/mtab if symbolic link. #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix
Impact: Normal
Reference to related issue (URL): Bind mount proc sys dev run at one place issue2045 #2047 (comment)
How was this pull request tested?
Full backup restore on Arch Linux with:
In the past when /etc/mtab was a regular file it was desirable to update disk UUIDs inside file (along with /etc/fstab)
When /etc/mtab become symbolic link pointing to /proc/mtab resp /proc/self/mtab, we don't want to perform any replacements with
sed -i(nor any other editor) because data are already up to date.