Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 470_safe_filesystems.sh for NSR #2058

Merged
merged 1 commit into from Mar 1, 2019
Merged

Update 470_safe_filesystems.sh for NSR #2058

merged 1 commit into from Mar 1, 2019

Conversation

hpannenb
Copy link
Contributor

@hpannenb hpannenb commented Feb 28, 2019

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Improvement/Others?

  • Impact: Low

  • Reference to related issue (URL): None.

  • How was this pull request tested? On a HP DL360 G9 / RHEL7.4

  • Brief description of the changes in this pull request:
    During the time working with the EMC Networker recovery I determined it is of additional use to not skip the retrieval of the filesystems in NSR_CLIENT_MODE I introduced with f09c3d3. It does not harm to do so since gathering this information is "read-only" for the client.
    Due to saving the save sets filesystem information in $VAR_DIR/recovery/nsr_paths within the recovery image one is able to retrieve/read this stored information during a recovery process i.e. for advising the EMC networker server team to recover the appropriate filesystem(-structure) from the backups beeing made.

It is of additional use to retrieve the filesystems in NSR_CLIENT_MODE; it does not harm since it is "read-only" on EMC Networker server. Due to saving the save sets filesystem information in $VAR_DIR/recovery/nsr_paths within the recovery image it is also possible to retrieve/read them during a recovery process.
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpannenb
I do not use NSR but according to your explanation
this change looks perfectly fine to me.

@jsmeix jsmeix requested a review from gdha February 28, 2019 10:44
@jsmeix jsmeix self-assigned this Feb 28, 2019
@jsmeix jsmeix added the enhancement Adaptions and new features label Feb 28, 2019
@jsmeix jsmeix added this to the ReaR v2.5 milestone Feb 28, 2019
@jsmeix
Copy link
Member

jsmeix commented Feb 28, 2019

@gdha
because you had approved #1584
you may also like to have a look here.

If you (or otheres) do not object I would "just merge" it tomorrow.

@jsmeix jsmeix merged commit 5c57224 into rear:master Mar 1, 2019
@jsmeix jsmeix added fixed / solved / done external tool The issue depends on other software e.g. third-party backup tools. labels Mar 1, 2019
@jsmeix
Copy link
Member

jsmeix commented Mar 1, 2019

@hpannenb
thank you for your continuous contributions to ReaR
that make ReaR work better with EMC Networker.

It is much appreciated because we at ReaR upstream
usually do not have third-party backup tools so that
we at ReaR upstream depend on contributions to ReaR
from users who actually use third-party backup tools.

@jsmeix jsmeix mentioned this pull request Jun 27, 2019
@hpannenb hpannenb deleted the patch-1 branch October 17, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants