Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have MODULES all_modules by default plus needed adaptions for that #2069

Merged

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented Mar 6, 2019

  • Type: Enhancement

  • Impact: Low

Hopefully low impact because this change should only
make things work better by default in the recovery system
without really bad side effects.
The somewhat bigger default recovery system should
not be a really bad side effect.

There is one backward incompatible change:
Before the user had to specify in local.conf

MODULES=( "${MODULES[@]}" 'moduleX' 'moduleY' )

to get additional kernel modules included
but now the user must specify

MODULES=( 'moduleX' 'moduleY' )

for that because with "${MODULES[@]}"
the default value all_modules would be kept
which triggers to get all modules included.

By me on my openSUSE Leap 15.0 system with

MODULES=( 'all_modules' )
MODULES=( 'loaded_modules' )
MODULES=( 'no_modules' )
MODULES=( 'hwpoison-inject' 'trusted' )
MODULES=()

and to me things look o.k.

  • Brief description of the changes in this pull request:

Now there is in default.conf

MODULES=( 'all_modules' )

which results that some additional adaptions were needed
in build/GNU/Linux/400_copy_modules.sh and conf/GNU/Linux.conf
because now the default value is no longer empty.

@jsmeix jsmeix added the enhancement Adaptions and new features label Mar 6, 2019
@jsmeix jsmeix added this to the ReaR v2.5 milestone Mar 6, 2019
@jsmeix jsmeix self-assigned this Mar 6, 2019
@jsmeix jsmeix requested a review from a team March 6, 2019 15:34
@jsmeix
Copy link
Member Author

jsmeix commented Mar 7, 2019

@rear/contributors
if there are no objections I would like to merge it today afternoon and
if hell breakes loose afterwards I can fix it or even revert it for ReaR 2.5. ;-)

Copy link
Member

@gdha gdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsmeix we will see how it goes - thanks for the enhancement.

@jsmeix jsmeix merged commit 2b2ca1a into rear:master Mar 7, 2019
@jsmeix jsmeix deleted the have_MODULES_all_modules_by_default_issue_2041 branch March 7, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants