New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore broken resolv conf in case of use dhclient issue 2018 #2076
Ignore broken resolv conf in case of use dhclient issue 2018 #2076
Conversation
@OliverO2 @rear/contributors |
@jsmeix As noted here #2018 (comment), this change would still require configuration change to resolve the issue. With this change, I would have the option of setting
while ReaR was working without any network-related configuration before. |
@OliverO2 Could you run |
@jsmeix Yes, as I've written elsewhere, I use DHCP, and I've briefly checked that this is what happens:
I'm sorry, it was my understanding that this PR would only work if |
As far as I could find out As far as I understand networking setup in the recovery system Accordingly I can currently not see how DHCP could be used |
@OliverO2 For the "fun" of it:
that is rightfully not detected by define_dhclients_variable() in |
…solv.conf in the recovery system
@jsmeix I have just tested it and can confirm that the rescue system generated from an auto-detected DHCP configuration on Ubuntu 18.04.2 LTS now works out of the box (i.e. no additional configuration required). Thank you, well done! |
@OliverO2 |
Type: Minor Bug Fix / Enhancement
Impact: Low
Reference to related issue (URL):
Improved setup of etc/resolv.conf in the recovery system (issue 2015) #2018 (comment)
How was this pull request tested?
By me on my openSUSE Leap 15.0 system
Brief description of the changes in this pull request:
Now build/GNU/Linux/630_verify_resolv_conf_file.sh does no longer error out
when etc/resolv.conf has no nameserver or only loopback addresses
and USE_DHCLIENT has a true value
(and USE_STATIC_NETWORKING does not have a true value)
because then etc/resolv.conf in the recovery system
is generated anew by /bin/dhclient-script
so that its content before does not matter.