Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable creation of non consecutive partitions #2081

Merged
merged 6 commits into from
May 24, 2019
Merged

Enable creation of non consecutive partitions #2081

merged 6 commits into from
May 24, 2019

Commits on May 24, 2019

  1. Enable creation of non consecutive partitions 

    Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    2039159 View commit details
    Browse the repository at this point in the history

  2. Included code review comments: 

    - no associative arrays
- no stderr redirection

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    ae861ba View commit details
    Browse the repository at this point in the history

  3. Handle 'parted resize' and 'parted resizepart' 

    Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    ede2f48 View commit details
    Browse the repository at this point in the history

  4. Added note about cleaning the code when parted doesn't support any unit 

    Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    f8bea2e View commit details
    Browse the repository at this point in the history

  5. Consider 'parted resize NUM START END' has not supporting resizing, b… 

    …ecause it tries to resize the underlying file system also, and this is usually not implemented into parted

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    8402bd1 View commit details
    Browse the repository at this point in the history

  6. Integrated review comment 

    Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
    @rmetrich
    rmetrich committed May 24, 2019
    Configuration menu
    Copy the full SHA
    b760aea View commit details
    Browse the repository at this point in the history