-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disk device name in efibootmgr call for eMMC devices #2104
Conversation
@fabz5 But currently it looks as if your additional conditional code Therefore I suggest this changed code
to keep the eMMC devices case more clearly separtated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From plain looking at the code (I don't have a eMMC device)
your changes look o.k. to me so I approve it.
But I would appreciate it if you could have a look at my proposal in
#2104 (comment)
if you could implement it this way - provided it still works then.
You are right of course, the coding was a bit sloppy. I guess it was too late at night when I did this. I will test your suggested changes and then recommit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now in this pull request there are also changes for
usr/share/rear/build/GNU/Linux/630_verify_resolv_conf_file.sh
which should not be part of this pull request.
(Facepalm) Sorry. This is not my day. I will fix this. |
After learning how to remove commits from pull requests I hope now it is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks good to me.
@rear/contributors |
@fabz5 |
Pull Request Details:
Type: Bug Fix / New Feature / Enhancement / Other?
Enhancement
Impact: Low / Normal / High / Critical / Urgent
Low
Reference to related issue (URL):
rear recover fails to create UEFI boot entry for eMMC device #2103
How was this pull request tested?
Manually on corresponding hardware (Z83-F Mini PC)
Brief description of the changes in this pull request:
For eMMC devices strip the trailing "p" in the disk device name,
so that during recovery the efibootmgr call will not fail, but create an UEFI boot entry.