Improvements and fixes for 950_copy_result_files (related to issue2137) #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because this is needed by @mutable-dan If there are issues with this changes here |
jsmeix
deleted the
improvements_and_fixes_for_950_copy_result_files_related_to_issue2137
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix
Impact: Normal
Reference to related issue (URL):
support for s390 (zLinux) arch #2142 (comment)
support for s390 (zLinux) arch #2142 (comment)
Support IBM Z architecture "s390x" (a.k.a. "z Systems" formerly "System/390") #2137
How was this pull request tested?
By me via
support for s390 (zLinux) arch #2142 (comment)
Brief description of the changes in this pull request:
Before output/default/950_copy_result_files.sh falsely errors out with
cf. #2142 (comment)
when
OUTPUT=FOOis used where nousr/share/rear/conf/templates/RESULT_usage_FOO.txt
exists.
Currently only
usr/share/rear/conf/templates/RESULT_usage_PXE.txt
usr/share/rear/conf/templates/RESULT_usage_RAMDISK.txt
usr/share/rear/conf/templates/RESULT_usage_ISO.txt
usr/share/rear/conf/templates/RESULT_usage_RAWDISK.txt
usr/share/rear/conf/templates/RESULT_usage_USB.txt
exists so that 950_copy_result_files.sh falsely errors out for all
other OUTPUT methods.
Additionally 950_copy_result_files.sh is now skipped
if RESULT_FILES is empty at the beginning of the script
because I think if there are no actual RESULT_FILES
it means there is no actual output and then is is useless
to copy VERSION and README and LOGFILE
to the output location.
I think it could be questionable if perhaps LOGFILE
should be always copied to the output location
even if there is no actual output.
If LOGFILE should be always copied to the output location
I can easily fix that.