Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let 420_autoresize_last_partitions.sh leave 33 blocks at end of GPT disks (issue #2182) #2188

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented Jul 17, 2019

When 420_autoresize_last_partitions.sh resizes the last partition
on a GPT disk it leaves 33 LBA blocks at the end of the disk
so that 420_autoresize_last_partitions.sh produces a fully correct
disklayout.conf file where no further automated adjustments by
a subsequent script like 100_include_partition_code.sh are done.

@jsmeix jsmeix added the bug The code does not do what it is meant to do label Jul 17, 2019
@jsmeix jsmeix added this to the ReaR v2.6 milestone Jul 17, 2019
@jsmeix jsmeix requested a review from a team July 17, 2019 12:20
@jsmeix jsmeix self-assigned this Jul 17, 2019
@jsmeix
Copy link
Member Author

jsmeix commented Jul 17, 2019

In a quick first test things look good to me:
I do no longer get a size reduced to fit on disk message in the log.

@jsmeix
Copy link
Member Author

jsmeix commented Jul 18, 2019

I checked the calculations of the new GPT related code
in 420_autoresize_last_partitions.sh and all looks good to me
so that will merge it soon if there are no objections right now.

@jsmeix jsmeix added the cleanup label Jul 18, 2019
@jsmeix jsmeix merged commit d412999 into rear:master Jul 18, 2019
@jsmeix jsmeix deleted the let_420_autoresize_last_partitions_leave_33_blocks_at_end_of_GPT_disk_issue2182 branch July 18, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do cleanup fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant