Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments to #2194 #2196

Merged
merged 1 commit into from Jul 30, 2019
Merged

Minor adjustments to #2194 #2196

merged 1 commit into from Jul 30, 2019

Conversation

pcahyna
Copy link
Member

@pcahyna pcahyna commented Jul 29, 2019

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
 # Format for LVM LVs
 # lvmvol <volume_group> <name> <size(bytes)> <layout> [key:value ...]
 # WARNING: Volume rhel_ibm-p9wr-08/home has multiple segments. Restoring it in Migration Mode using 'lvcreate' won't preserve segments and properties of the other segments as well!
-lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear segmentsize:2000393601024b
-#lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear segmentsize:1941333606400b
+lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear 
+# extra parameters for the line above not taken into account when restoring using 'lvcreate': segmentsize:2000393601024b
+#lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear 
+# extra parameters for the line above not taken into account when restoring using 'lvcreate': segmentsize:1941333606400b
  • Brief description of the changes in this pull request:
    Minor adjustments to Issue #2187 - disklayout.conf file contains duplicate lines #2194. Do not overload the kval variable - intended for passing options to lvcreate - by adding extra keys to it, which are not supported by lvcreate. Introduce another variable infokval for this purpose and print those unsupported and purely informational keys only in comments.

Do not overload the `kval` variable - intended for passing options
to lvcreate - by adding extra keys to it, which are not supported
by lvcreate.
Introduce another variable `infokval` for this purpose and print
those unsupported and purely informational keys only in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants