New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not abort in case of invalid user input but retry #2257
Do not abort in case of invalid user input but retry #2257
Conversation
@schabrolles @gdha |
There is also
which could benefit from such an enhancement. The following scripts look also suspicious:
For next week (if time permits)... |
When there are no objections I would like to "just merged" it |
…id user date and time input but retry
… by plain looking at the code
I think this one is sufficiently complete and consistent now I kept WAIT_SECS as separated user config variable for now |
I "just merged" it so that things can be tested right now Please report if there are regressions so that I can fix them, |
With #2257 merged plus I would appreciate it if ReaR users in particular those who |
Type: Enhancement
Impact: Low
Reference to related issue (URL):
Do not abort 'rear recover' in case of invalid user input - let the user retry if possible #2253
How was this pull request tested?
I tested the plain code by running it as a separated script
and for me the input seems to work o.k.
but I cannot actually test it with TSM or NBU
because I have neither of them.
Brief description of the changes in this pull request:
Let the user enter date and time again and again until the input is valid
or the user pressed only ENTER to restore the most recent available backup.
Replaced 'LogPrint' with 'UserOutput' because
the former shows messsages only in verbose mode
while the latter shows messages always to the user
(this does not matter in practice during 'rear recover'
but 'UserOutput' is the ceaner code for user output
and I noticed that in my separated test script).