Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 650_check_iso_recoverable.sh #2271

Merged
merged 1 commit into from Nov 6, 2019
Merged

Update 650_check_iso_recoverable.sh #2271

merged 1 commit into from Nov 6, 2019

Conversation

hpannenb
Copy link
Contributor

@hpannenb hpannenb commented Nov 1, 2019

Pull Request Details:
  • Type: Bug Fix

  • Impact: Low

  • Reference to related issue (URL):
    NSRSERVER is missing #2162

  • How was this pull request tested?
    see NSRSERVER is missing #2162 (comment)

  • Brief description of the changes in this pull request:
    Removed the (unnecessary) line in the code of 650_check_iso_recoverable.sh which prevents manually setting the NSRSERVER variable in i.e. local.conf

This should fix issue #2162. Please test.
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about NSR so I blindly trust @hpannenb

@jsmeix jsmeix requested a review from a team November 4, 2019 13:00
@jsmeix jsmeix self-assigned this Nov 4, 2019
@jsmeix jsmeix added enhancement Adaptions and new features minor bug An alternative or workaround exists labels Nov 4, 2019
@jsmeix jsmeix added this to the ReaR v2.6 milestone Nov 4, 2019
@jsmeix
Copy link
Member

jsmeix commented Nov 4, 2019

@hpannenb
thank you for your continuous improvements
of the NSR related code in ReaR!

@rear/contributors
if there are no objections from other ReaR maintainers
I would like to merge it tomorrow afternoon.

@jsmeix
Copy link
Member

jsmeix commented Nov 4, 2019

@hpannenb
FYI regarding setting a variable to a default/fallback value
unless the user had it already set, you may have a look at
how I try to achieve that in default.conf via

test "$VAR" || VAR="default_value"

for example see
https://github.com/rear/rear/blob/master/usr/share/rear/conf/default.conf#L226

@jsmeix jsmeix mentioned this pull request Nov 5, 2019
@jsmeix jsmeix merged commit 420c177 into rear:master Nov 6, 2019
@jsmeix jsmeix added fixed / solved / done external tool The issue depends on other software e.g. third-party backup tools. labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants