New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2281(missing delete_dummy_partitions_and_resize_real_ones calls) #2295
Conversation
…'" was outputted instead of "End of code handling disk '/dev/<device>'"
…used (Software Raid can have partitions since these are virtual disks
…lar disks), including MBR erasing and partition creation and cleanup create_multipath() cannot call create_disk() because create_disk() verifies that the device is a block device, which it isn't with multipath because it's a symlink to a device mapper instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from plain looking at the code changes.
@rmetrich Ony as a side note a question FYI: As far as I see we have now the same code
in three scripts:
in each one directly after the I am wondering if that code could be moved
Or what is the reason why code like
cannot be added at the end of the Perhaps the reason is obvious but I still do not see it. |
The idea behind create_partitions is to create partitions, but we want to let the admin create additional ones if he needs to. Hence the code being split. |
@pcahyna we may need this. |
See #2281 for details.