Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added $FDRUPSTREAM_DATA_PATH/rear to $COPY_AS_IS_EXCLUDE_FDRUPSTREAM #2318

Merged
merged 1 commit into from Jan 21, 2020

Conversation

rowens275
Copy link
Contributor

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL):

  • How was this pull request tested?
    Put large files in $FDRUPSTREAM_DATA_PATH/rear and verify that image created by 'rear mkrescue' does not include those large files.

  • Brief description of the changes in this pull request:
    We are working on changes to the FDR/Upstream ReaR workflow, and under certain conditions will put the ReaR output files in $FDRUPSTREAM_DATA_PATH/rear. So on subsequent runs of 'rear mkrescue', we do not want to include that directory in the image since it serves no purpose and it causes the image to grow in size each time 'rear mkrescue' is run. In effect, it is a recursive backup. This pull request is intended to eliminate that problem.

@jsmeix jsmeix added enhancement Adaptions and new features external tool The issue depends on other software e.g. third-party backup tools. labels Jan 21, 2020
@jsmeix jsmeix added this to the ReaR v2.6 milestone Jan 21, 2020
@jsmeix
Copy link
Member

jsmeix commented Jan 21, 2020

@rowens275
thank you for your enhancements for BACKUP=FDRUPSTREAM!

Could you also add a comment to usr/share/rear/conf/default.conf
that describes the reason behind why $FDRUPSTREAM_DATA_PATH/rear
and $FDRUPSTREAM_INSTALL_PATH/usserver are excluded from the
backup (i.e. why the files in those $FDRUPSTREAM_DATA_PATH directories
do not make sense in the backup) so that other FDR/Upstream users could
easily understand the reason behind.

Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a FDR/Upstream user so all I can do is looking at the code.
From plain looking at the code things look o.k. to me so I approve it.

@jsmeix jsmeix requested a review from a team January 21, 2020 09:40
@jsmeix
Copy link
Member

jsmeix commented Jan 21, 2020

I would like to have one more approval from another ReaR maintainer.

Copy link
Member

@gdha gdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot do any harm, so I'm ok with it.

@gdha gdha self-assigned this Jan 21, 2020
@gdha gdha merged commit a46e0f9 into rear:master Jan 21, 2020
jsmeix added a commit that referenced this pull request Jan 21, 2020
Explain why $FDRUPSTREAM_DATA_PATH/rear is excluded from the backup
see #2318 (comment)
@jsmeix
Copy link
Member

jsmeix commented Jan 21, 2020

@gdha
in general default exludes from the backup could do harm
(i.e. when needed files are missing from the backup) so an
explanation when things are excluded by default from the backup
is needed:
d0d78bf

@rowens275 rowens275 deleted the us-1393 branch February 4, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Adaptions and new features external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants