Home directory of root user is not hard-coded any more. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Real home directory of root user is used instead of "/root" string.
jsmeix
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
From plain looking at the changes all looks good to me.
I found another place where a hardcoded /root is used:
usr/share/rear/wrapup/default/990_copy_logfile.sh
recovery_system_roots_home_dir=$TARGET_FS_ROOT/root
I think also in this case it must be
recovery_system_roots_home_dir=$TARGET_FS_ROOT/$ROOT_HOME_DIR
FYI: The variable name recovery_system_roots_home_dir means
"path to root's home dir in the restored system from within the recovery system"
and not "root's home dir in the recovery system".
I failed to construct a not too long variable name that is unambiguous what it is.
Perhaps target_system_roots_home_dir would be a better name?
|
Hello @jsmeix Thanks, I'll fix that, too! V. |
$ROOT_HOME_DIR on couple more places.
gdha
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Enhancement
Impact: Normal
Reference to related issue (URL): Hard-coded home directory of root #2331
How was this pull request tested?
Full backup/restore with:
Brief description of the changes in this pull request:
This patch removes hard-coded location of root home directory (/root) from ReaR code, and replaces it with global configuration variable ROOT_HOME_DIR. This allows to correctly track home directory of root user even when a non-default location is used.