Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2349: OPALPBA: cannot change password on multiple SEDs at once #2350

Merged
merged 1 commit into from Mar 31, 2020
Merged

Fix #2349: OPALPBA: cannot change password on multiple SEDs at once #2350

merged 1 commit into from Mar 31, 2020

Conversation

OliverO2
Copy link
Contributor

Pull Request Details:

jsmeix
jsmeix approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I don't know about OPALPBA I just blindly approve it.

@jsmeix jsmeix self-assigned this Mar 31, 2020
@jsmeix jsmeix added the enhancement Adaptions and new features label Mar 31, 2020
@jsmeix jsmeix added this to the ReaR v2.6 milestone Mar 31, 2020
@jsmeix
Copy link
Member

jsmeix commented Mar 31, 2020

@OliverO2
thank you for your continuous testing and improving
OPALPBA support in ReaR.

If you do not object I would like to merge it today evening.

@OliverO2
Copy link
Contributor Author

@jsmeix
Yes, I'm absolutely fine with merging today. Thanks!

Side note: Should probably be labelled fix as the change corrects a logic error. The functionality was meant to work in the first place.

@jsmeix jsmeix added minor bug An alternative or workaround exists and removed enhancement Adaptions and new features labels Mar 31, 2020
@jsmeix jsmeix merged commit 04fe323 into rear:master Mar 31, 2020
@jsmeix jsmeix mentioned this pull request Mar 31, 2020
Closed
@OliverO2 OliverO2 deleted the fix-opaladmin branch March 31, 2020 16:38
@jsmeix jsmeix mentioned this pull request Jun 2, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmeix jsmeix jsmeix approved these changes

Assignees

@jsmeix jsmeix

Labels
fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Milestone
ReaR v2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OliverO2 @jsmeix