Error out when LUKS version 2 is used (issue #2204) #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error out during "rear mkrescue/mkbackup" when LUKS version 2 is used. LUKS version 2 is not suppported, see #2204 When LUKS version 2 is used it fails at least to determine the hash value so we use an empty hash value as a simple test if gathering crypt information was successful and error out if not.
|
If there are no objections I would like to merge it today afternoon. |
More fail-safe error message text now using "... LUKS device '$target_name' at '$source_device' ..." that looks OK even if $target_name or $source_device are empty so the user can see that things are missing in "... LUKS device '' at '' ..." instead of what it was before "... LUKS device /dev/mapper/$target_name at $source_device ..." which would have shown confusing/misspelled/wrong output to the user when $target_name or $source_device are empty like "... LUKS device /dev/mapper/ at (only ..." (`/dev/mapper` is no device but a directory and what is 'at'?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Minor Bug Fix
It is a minor bug when "rear mkrescue/mkbackup" does not error out
when things have actually failed.
In this case when gathering crypt information was not successful
the code blindly proceeds resulting wrong (incomplete) entries
in disklayout.conf that let later (when it is too late) "rear recover" fail.
Impact: High
Reference to related issue (URL):
Failed to recover LUKS version 2 #2204
How was this pull request tested?
By me on my current homeoffice laptop that uses LUKS 1.
I get still same 'crypt' entries in disklayout conf.
Brief description of the changes in this pull request:
Error out during "rear mkrescue/mkbackup" when LUKS version 2 is used
because currently LUKS version 2 is not suppported.
When LUKS version 2 is used it fails at least to determine the hash value cf.
Failed to recover LUKS version 2 #2204 (comment)
so we use an empty hash value as a simple test if gathering crypt information
was successful and error out if not.