Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "--type luks1" to the default LUKS_CRYPTSETUP_OPTIONS #2437

Merged
merged 1 commit into from Jun 30, 2020
Merged

Add "--type luks1" to the default LUKS_CRYPTSETUP_OPTIONS #2437

merged 1 commit into from Jun 30, 2020

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented Jun 23, 2020

@jsmeix
Update default.conf
8504e0d 
Add "--type luks1" to the default LUKS_CRYPTSETUP_OPTIONS
to fix #2432
@jsmeix jsmeix added enhancement Adaptions and new features minor bug An alternative or workaround exists labels Jun 23, 2020
@jsmeix jsmeix added this to the ReaR v2.7 milestone Jun 23, 2020
@jsmeix jsmeix requested a review from a team June 23, 2020 12:56
@jsmeix jsmeix self-assigned this Jun 23, 2020
@jsmeix jsmeix mentioned this pull request Jun 23, 2020
Closed
@jsmeix
Copy link
Member Author

jsmeix commented Jun 24, 2020

When there are no ojbections I would like to merge it tomorrow afternoon.

@jsmeix
Copy link
Member Author

jsmeix commented Jun 25, 2020

According to
#2432 (comment)
I will wait for review by @OliverO2 next week.

@OliverO2
Copy link
Contributor

Test Results on Ubuntu 20.04 LTS

  • rear mkrescue / rear recover without commit 8504e0d

    RESCUE juliet:~ # cryptsetup luksDump /dev/sdb1
LUKS header information
Version:       	2
[...]

  • rear mkrescue / rear recover with commit 8504e0d

    RESCUE juliet:~ # cryptsetup luksDump /dev/sdb1
LUKS header information for /dev/sdb1

Version:       	1
[...]

So this patch solves the issue on Ubuntu 20.04 LTS as expected.

@jsmeix jsmeix merged commit 8472a67 into master Jun 30, 2020
@jsmeix jsmeix deleted the jsmeix-cryptsetup-add-type-luks1 branch June 30, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsmeix jsmeix

Labels
enhancement Adaptions and new features fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Milestone
ReaR v2.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsmeix @OliverO2