Cleanup using $DATE #2452
Merged
Cleanup using $DATE #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing somewhat obscure $DATE usage with fixed and consistent variables.
Use $START_DATE_TIME_NUMBER instead of $DATE
Use $START_DATE_TIME_NUMBER instead of $DATE
Replace $STARTTIME usage with $START_SECONDS usage
Removed setting STARTTIME because its only usage in framework-functions.sh was replace with using $START_SECONDS instead, cf. b35cbbc
|
I dislike meaningless variable names so much that I just needed to do this cleanup . |
schlomo
approved these changes
Jul 3, 2020
|
I have tested it quickly on my local system. |
Better explanatory comment why one must not call the 'date' command several times when one same point in time should be used for different date and time formats.
gdha
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing somewhat obscure $DATE usage
with fixed and consistent variables.