Makefile: fix warning "jobserver unavailable: using -j1" #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running "make install" make throws warnings make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. Fix: do not call "make" inside a Makefile, use "$(MAKE)" instead
gdha
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
@madmartin good catch - thank you for the enhancement of the Makefile
jsmeix
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
I know nothing about make details but according to
https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html
Recursive make commands should always use the variable MAKE,
not the explicit command name ‘make’
the change in this pull request seems to be the right thing to do in general
so I approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details:
Type: Bug Fix
Impact: Normal
Reference to related issue (URL):
N/A
How was this pull request tested?
The issue occurred when creating a gentoo ebuild for the 2.6 release
Brief description of the changes in this pull request:
when running "make install" make throws warnings
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.Fix: do not call "make" inside a Makefile, use "$(MAKE)" instead
For reference, see
https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html