ISO_FILE_SIZE_LIMIT: provide final power to the user to skip the ISO_FILE_SIZE_LIMIT test #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the assert_ISO_FILE_SIZE_LIMIT function when there is no usable ISO_FILE_SIZE_LIMIT set so the user could specify ISO_FILE_SIZE_LIMIT=0 or ISO_FILE_SIZE_LIMIT="no" in his etc/rear/local.conf if he wants to skip the ISO_FILE_SIZE_LIMIT test.
Explain that the ISO_FILE_SIZE_LIMIT test can be skipped with ISO_FILE_SIZE_LIMIT=0 in etc/rear/local.conf
For 'ebiso' the ISO_FILE_SIZE_LIMIT test must not be skipped with ISO_FILE_SIZE_LIMIT=0
More exact text about the cases where ISO 9660 level 1 or 2 is used that has a 2GiB file size limit.
More clear comment that assert_ISO_FILE_SIZE_LIMIT is skipped in particular for ISO_FILE_SIZE_LIMIT=0
Enforce 2GiB ISO_FILE_SIZE_LIMIT when the MODULES array contains 'loaded_modules' because MODULES+=( udf ) has no effect in this case unless it is loaded (which normally isn't) except the user has specified to skip the ISO_FILE_SIZE_LIMIT test with ISO_FILE_SIZE_LIMIT=0
Enforce 2GiB ISO_FILE_SIZE_LIMIT when the MODULES array contains 'loaded_modules' but keep what the user has specified if ISO_FILE_SIZE_LIMIT is specified less than 2GiB.
|
With my latest commits things work well for me. |
Explain that nothing is done for ISO_FILE_SIZE_LIMIT when the MODULES array contains 'no_modules' because that is meant for experts who know what they do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Enhancement
Impact: Normal
Reference to related issue (URL):
Error out when files greater or equal ISO_FILE_SIZE_LIMIT should be included in the ISO #2525
How was this pull request tested?
See ISO_FILE_SIZE_LIMIT: provide final power to the user to skip the ISO_FILE_SIZE_LIMIT test #2533 (comment)
Brief description of the changes in this pull request:
Skip the assert_ISO_FILE_SIZE_LIMIT function
when there is no usable ISO_FILE_SIZE_LIMIT set
so the user could specify
ISO_FILE_SIZE_LIMIT=0or
ISO_FILE_SIZE_LIMIT="no"in his etc/rear/local.confif he wants to skip the ISO_FILE_SIZE_LIMIT test.