Better ACLs handling #260
Merged
Better ACLs handling #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A comma as IFS is irrelevant because we need options separated by comma in one block. (eg : default_mount_options) Also, it breaks the loop because spaces are used as separator in disklayout.conf.
It's usefull in the case we want to restore ACL of all users.
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request intents to fix and improve Rear handling of ACLs
1. Regression fix
First, there is a commit which fix a regression introduced by 2d54454 (in 13_include_fs_code).
As I already explained, tune2fs options parsing is broken because the field separator in disklayout.conf is a space.
Also, a comma as separator is a non sense because multiple options must be keep together (eg: default_mount_options)
2. Default mount options saving (dependent of the previous commit)
In RHEL, the default installer behaviour on EXT* FS is to keep the acl mount option as a default mount option.
So, this commit fix that by saving them in disklayout.conf and then restoring them in the same way as the other tune2fs options.
3. Copy of users and groups
I added a new variable (CLONE_ALL_USERS_GROUPS) to allow the end user to use all its users and groups on the rescue media. Of course, it overrides CLONE_USERS and CLONE_GROUPS if defined to y. By default it's set to n, so it's the current behaviour.
Only users not already in the Rear default passwd/group files are copied.
An option like that can be usefull in the case of ACLs defined for local users which can't be restored whithout the user defined ("cannot acl from text" error)